From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
To: ext Gerrit Renker <gerrit@erg.abdn.ac.uk>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Resent][PATCH 1/2] inet6: Conversion from u8 to int
Date: Mon, 10 Aug 2009 09:33:10 +0300 [thread overview]
Message-ID: <200908100933.11676.remi.denis-courmont@nokia.com> (raw)
In-Reply-To: <1249841569-23706-2-git-send-email-gerrit@erg.abdn.ac.uk>
On Sunday 09 August 2009 21:12:48 ext Gerrit Renker wrote:
> case IPV6_TCLASS:
> val = np->tclass;
> - if (val < 0)
> - val = 0;
> break;
According to the IPv6 API RFC, if val is -1, the kernel shall pick the default
value (which is zero). Are you sure this still works??
--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
next prev parent reply other threads:[~2009-08-10 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <resolve_IPV6_TCLASS>
2009-08-09 18:12 ` [PATCH 0/2] inet6: resolve IPV6_TCLASS conversion problems Gerrit Renker
2009-08-09 18:12 ` [Resent][PATCH 1/2] inet6: Conversion from u8 to int Gerrit Renker
2009-08-09 18:12 ` [PATCH 2/2] inet6: Set default traffic class Gerrit Renker
2009-08-10 6:33 ` Rémi Denis-Courmont [this message]
2009-08-10 7:08 ` [Resent][PATCH 1/2] inet6: Conversion from u8 to int ext Gerrit Renker
2009-08-13 23:28 ` [PATCH 0/2] inet6: resolve IPV6_TCLASS conversion problems David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908100933.11676.remi.denis-courmont@nokia.com \
--to=remi.denis-courmont@nokia.com \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox