From: Stephen Hemminger <shemminger@vyatta.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: vibi_sreenivasan@cms.com, netdev <netdev@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Thomas Graf <tgraf@suug.ch>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: [PATCH] Fix Warnings from net/netlink/genetlink.c
Date: Tue, 11 Aug 2009 20:24:59 -0700 [thread overview]
Message-ID: <20090811202459.7f98e496@nehalam> (raw)
In-Reply-To: <1250035061.30166.42.camel@localhost.localdomain>
On Tue, 11 Aug 2009 16:57:41 -0700
Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Vibi,
>
> > net/netlink/genetlink.c: In function `genl_register_mc_group':
> > net/netlink/genetlink.c:139: warning: 'err' might be used uninitialized in this function
> >
> > Signed-off-by: vibi sreenivasan <vibi_sreenivasan@cms.com>
> > ---
> > net/netlink/genetlink.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
> > index 575c643..66f6ba0 100644
> > --- a/net/netlink/genetlink.c
> > +++ b/net/netlink/genetlink.c
> > @@ -136,7 +136,7 @@ int genl_register_mc_group(struct genl_family *family,
> > {
> > int id;
> > unsigned long *new_groups;
> > - int err;
> > + int err = 0;
> >
> > BUG_ON(grp->name[0] == '\0');
>
> this looks fishy. How does gcc thinks this variable is uninitialized. If
> I look at the code in Linus' tree, I don't see it.
Agreed, and the line numbers are off.
--
next prev parent reply other threads:[~2009-08-12 3:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 10:07 [PATCH] Fix Warnings from net/netlink/genetlink.c vibi sreenivasan
2009-08-11 23:57 ` Marcel Holtmann
2009-08-12 3:24 ` Stephen Hemminger [this message]
2009-08-12 3:50 ` Stephen Rothwell
2009-08-12 4:03 ` Marcel Holtmann
[not found] <1249975630.2400.7.camel@HunTEr>
2009-08-11 7:36 ` Johannes Berg
2009-08-11 9:15 ` vibi sreenivasan
2009-08-11 9:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811202459.7f98e496@nehalam \
--to=shemminger@vyatta.com \
--cc=johannes@sipsolutions.net \
--cc=linux-next@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=vibi_sreenivasan@cms.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).