From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: netdev@vger.kernel.org, yanivr@broadcom.com, vladz@broadcom.com,
gertner@broadcom.com, benli@broadcom.com
Subject: Re: [net-next 00/36] bnx2x patch series
Date: Wed, 12 Aug 2009 14:50:19 -0700 (PDT) [thread overview]
Message-ID: <20090812.145019.231249971.davem@davemloft.net> (raw)
In-Reply-To: <1250101162.27379.151.camel@lb-tlvb-eilong>
Come on... 36 patches? :-/
Please trickle changes in, don't send patch bombs. I think
I've told you this not once, but several times. But I keep
seeing these sizable patch sets.
I frankly don't care that it might not mesh well with how you code up
and validate changes internally, because it absolutely does NOT work
well for how bugs really get found and fixed upstream.
If you trickle changes in, the guilty change is obvious to spot and it
gets found before you do more development that depends upon that buggy
change.
Whereas if you patch bomb, someone has to do a lot of work and
bisecting to nail down the bad change. And the bug might be so
fundamental in a patch that it also invalidates all the followon
work you did.
I really don't want to apply any of this stuff, to be honest with you.
I simply don't. I keep giving guidelines and they keep getting
ignored.
next prev parent reply other threads:[~2009-08-12 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 18:19 [net-next 00/36] bnx2x patch series Eilon Greenstein
2009-08-12 21:50 ` David Miller [this message]
2009-08-13 6:09 ` David Miller
2009-08-13 6:35 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812.145019.231249971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benli@broadcom.com \
--cc=eilong@broadcom.com \
--cc=gertner@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
--cc=yanivr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox