From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/net/tokenring: Use status field rather than state field
Date: Wed, 12 Aug 2009 21:19:07 -0700 (PDT) [thread overview]
Message-ID: <20090812.211907.124112530.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0908080846000.25176@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sat, 8 Aug 2009 08:47:33 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> In general in this file, it is the status field, not the state field, that
> contains values like OPEN and CLOSED. Indeed, in the first error case, it
> is the field status that is initialized. I have thus assumed that all of
> the error handling code should be the same, and moved it to the end of the
> function to emphasize its commonality.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
prev parent reply other threads:[~2009-08-13 4:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 6:47 [PATCH] drivers/net/tokenring: Use status field rather than state field Julia Lawall
2009-08-13 4:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812.211907.124112530.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox