From: Arnd Bergmann <arnd@arndb.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
"Ira W. Snyder" <iws@ovro.caltech.edu>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vhost_net: a kernel-level virtio server
Date: Thu, 13 Aug 2009 16:58:06 +0200 [thread overview]
Message-ID: <200908131658.06522.arnd@arndb.de> (raw)
In-Reply-To: <20090813143922.GA5080@redhat.com>
On Thursday 13 August 2009, Michael S. Tsirkin wrote:
> > Right now, the number of copy operations in your code is the same.
> > You are doing the copy a little bit later in skb_copy_datagram_iovec(),
> > which is indeed a very nice hack. Changing to a virtqueue based method
> > would imply that the host needs to add each skb_frag_t to its outbound
> > virtqueue, which then gets copied into the guests inbound virtqueue.
>
> Which is a lot more code than just calling skb_copy_datagram_iovec.
Well, I don't see this part as much of a problem, because the code
already exists in virtio_net. If we really wanted to go down that road,
just using virtio_net would solve the problem of frame handling
entirely, but create new problems elsewhere, as we have mentioned.
Arnd <><
next prev parent reply other threads:[~2009-08-13 14:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1249930169.git.mst@redhat.com>
2009-08-10 18:53 ` [PATCH 1/2] export cpu_tlbstate to modules Michael S. Tsirkin
2009-08-10 21:56 ` H. Peter Anvin
2009-08-10 22:06 ` Michael S. Tsirkin
2009-08-10 22:24 ` H. Peter Anvin
2009-08-11 11:19 ` Michael S. Tsirkin
2009-08-10 18:53 ` [PATCH 2/2] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-08-10 19:51 ` Arnd Bergmann
2009-08-10 20:10 ` Michael S. Tsirkin
2009-08-10 22:16 ` Arnd Bergmann
2009-08-12 17:03 ` Arnd Bergmann
2009-08-12 17:19 ` Ira W. Snyder
2009-08-12 17:31 ` Michael S. Tsirkin
2009-08-12 17:48 ` Ira W. Snyder
2009-08-13 5:55 ` Michael S. Tsirkin
2009-08-12 17:21 ` Michael S. Tsirkin
2009-08-12 17:59 ` Arnd Bergmann
2009-08-12 19:27 ` Anthony Liguori
2009-08-13 6:31 ` Michael S. Tsirkin
2009-08-13 6:06 ` Michael S. Tsirkin
2009-08-13 13:38 ` Arnd Bergmann
2009-08-13 13:48 ` Arnd Bergmann
2009-08-13 14:41 ` Michael S. Tsirkin
2009-08-13 14:53 ` Arnd Bergmann
2009-08-13 15:37 ` Avi Kivity
2009-08-20 7:25 ` Rusty Russell
2009-08-13 14:39 ` Michael S. Tsirkin
2009-08-13 14:58 ` Arnd Bergmann [this message]
2009-08-13 15:03 ` Michael S. Tsirkin
2009-08-12 19:22 ` Anthony Liguori
2009-08-13 8:45 ` Michael S. Tsirkin
2009-08-13 13:45 ` Arnd Bergmann
2009-08-12 19:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908131658.06522.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=iws@ovro.caltech.edu \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).