From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Fischer, Anna" <anna.fischer@hp.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ptcongdon@ucdavis.edu" <ptcongdon@ucdavis.edu>,
"evb@yahoogroups.com" <evb@yahoogroups.com>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"kaber@trash.net" <kaber@trash.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"Dickson, Mike (ISS Software)" <mike.dickson@hp.com>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"bridge@osdl.org" <bridge@linux-foundation.org>
Subject: Re: [RFC] bridge: prevent hairpin and STP problems?
Date: Mon, 17 Aug 2009 15:37:25 -0700 [thread overview]
Message-ID: <20090817153725.47c04fca@nehalam> (raw)
In-Reply-To: <0199E0D51A61344794750DC57738F58E6D6B0C79D7@GVW1118EXC.americas.hpqcorp.net>
On Mon, 17 Aug 2009 21:16:04 +0000
"Fischer, Anna" <anna.fischer@hp.com> wrote:
> > Subject: [RFC] bridge: prevent hairpin and STP problems?
> >
> > Do we need to add this to block Spanning Tree from being enabled
> > with hairpin mode? I am not sure what the exact usage of hairpin
> > mode and if it is possible to create loops and get STP confusion.
> >
> > For comment only, do not apply as is.
>
> Your patch disables STP on the whole bridge if one or more ports
> are set to hairpin mode.
>
> However, I don't really see that this is necessary.
>
> A hairpin mode port should not reflect BPDUs, because otherwise the
> connected port would think it has detected a loop. The hairpin mode
> port should still be able to generate BPDUs though, and in any case
> the bridge should still be able to run STP.
>
> The hairpin patch we submitted reflects packets on the forwarding /
> data path whereas BPDUs are processed with a separate hook, so we
> should not be reflecting BPDUs back out of a hairpin mode port.
So if user is using hairpin properly, the STP would work. In fact
it would be a good thing since it would detect looping configurations.
prev parent reply other threads:[~2009-08-17 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 16:55 [PATCH] net/bridge: Add 'hairpin' port forwarding mode Fischer, Anna
2009-08-13 17:06 ` Arnd Bergmann
2009-08-13 18:07 ` Stephen Hemminger
2009-08-13 23:27 ` David Miller
2009-08-14 21:41 ` [RFC] bridge: prevent hairpin and STP problems? Stephen Hemminger
2009-08-17 21:16 ` Fischer, Anna
2009-08-17 22:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817153725.47c04fca@nehalam \
--to=shemminger@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=anna.fischer@hp.com \
--cc=arnd@arndb.de \
--cc=bridge@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=evb@yahoogroups.com \
--cc=kaber@trash.net \
--cc=mike.dickson@hp.com \
--cc=netdev@vger.kernel.org \
--cc=ptcongdon@ucdavis.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).