From: Stephen Hemminger <shemminger@vyatta.com>
To: John Linn <john.linn@xilinx.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
jgarzik@pobox.com, davem@davemloft.net,
John Linn <john.linn@xilinx.com>,
Grant Likely <grant.likely@secretlab.ca>,
Josh Boyer <jwboyer@linux.vnet.ibm.com>,
John Williams <john.williams@petalogix.com>,
Michal Simek <michal.simek@petalogix.com>,
Sadanand M <sadanan@xilinx.com>
Subject: Re: [PATCH] net: add Xilinx emac lite device driver
Date: Tue, 18 Aug 2009 14:04:18 -0700 [thread overview]
Message-ID: <20090818140418.347cb8ac@nehalam> (raw)
In-Reply-To: <20090818153047.48E42ED8051@mail66-dub.bigfish.com>
On Tue, 18 Aug 2009 09:30:41 -0600
John Linn <john.linn@xilinx.com> wrote:
> +/**
> + * xemaclite_enable_interrupts - Enable the interrupts for the EmacLite device
> + * @drvdata: Pointer to the Emaclite device private data
> + *
> + * This function enables the Tx and Rx interrupts for the Emaclite device along
> + * with the Global Interrupt Enable.
> + */
> +static void xemaclite_enable_interrupts(struct net_local *drvdata)
Docbook format is really a not necessary on local functions that
are only used in the driver. It is fine if you want to use it, as
long as the file isn't processed by kernel make docs but
the docbook is intended for automatic generation of kernel API manuals.
--
next prev parent reply other threads:[~2009-08-18 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 15:30 [PATCH] net: add Xilinx emac lite device driver John Linn
2009-08-18 21:04 ` Stephen Hemminger [this message]
2009-08-19 7:20 ` John Linn
2009-08-19 6:28 ` David Miller
2009-08-19 7:13 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818140418.347cb8ac@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=jgarzik@pobox.com \
--cc=john.linn@xilinx.com \
--cc=john.williams@petalogix.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michal.simek@petalogix.com \
--cc=netdev@vger.kernel.org \
--cc=sadanan@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).