* [PATCH -next] net: fix ks8851 build errors
[not found] <20090818184215.fdf1c7ae.sfr@canb.auug.org.au>
@ 2009-08-18 22:27 ` Randy Dunlap
2009-08-19 3:12 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2009-08-18 22:27 UTC (permalink / raw)
To: Stephen Rothwell, netdev, akpm; +Cc: linux-next, LKML, davem
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build errors due to missing Kconfig selects:
ks8851.c:(.text+0x7d2ee): undefined reference to `crc32_le'
ks8851.c:(.text+0x7d2f5): undefined reference to `bitrev32'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20090818.orig/drivers/net/Kconfig
+++ linux-next-20090818/drivers/net/Kconfig
@@ -1733,6 +1733,8 @@ config KS8851
tristate "Micrel KS8851 SPI"
depends on SPI
select MII
+ select CRC32
+ select BITREVERSE
help
SPI driver for Micrel KS8851 SPI attached network chip.
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] net: fix ks8851 build errors
2009-08-18 22:27 ` [PATCH -next] net: fix ks8851 build errors Randy Dunlap
@ 2009-08-19 3:12 ` David Miller
2009-08-19 15:52 ` [PATCH v2] " Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-08-19 3:12 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, netdev, akpm, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 18 Aug 2009 15:27:05 -0700
> --- linux-next-20090818.orig/drivers/net/Kconfig
> +++ linux-next-20090818/drivers/net/Kconfig
> @@ -1733,6 +1733,8 @@ config KS8851
> tristate "Micrel KS8851 SPI"
> depends on SPI
> select MII
> + select CRC32
> + select BITREVERSE
> help
> SPI driver for Micrel KS8851 SPI attached network chip.
>
CRC32 alone is sufficient, because it, in turn, selects BITREVERSE
When you resubmit with this simplification, I'll apply the
patch to net-2.6 since the problem exists in Linus's tree
too, not just -next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] net: fix ks8851 build errors
2009-08-19 3:12 ` David Miller
@ 2009-08-19 15:52 ` Randy Dunlap
2009-08-19 19:13 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2009-08-19 15:52 UTC (permalink / raw)
To: David Miller; +Cc: sfr, netdev, akpm, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build errors due to missing Kconfig select of CRC32:
ks8851.c:(.text+0x7d2ee): undefined reference to `crc32_le'
ks8851.c:(.text+0x7d2f5): undefined reference to `bitrev32'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20090818.orig/drivers/net/Kconfig
+++ linux-next-20090818/drivers/net/Kconfig
@@ -1733,6 +1733,7 @@ config KS8851
tristate "Micrel KS8851 SPI"
depends on SPI
select MII
+ select CRC32
help
SPI driver for Micrel KS8851 SPI attached network chip.
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: fix ks8851 build errors
2009-08-19 15:52 ` [PATCH v2] " Randy Dunlap
@ 2009-08-19 19:13 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-08-19 19:13 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, netdev, akpm, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 19 Aug 2009 08:52:02 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build errors due to missing Kconfig select of CRC32:
>
> ks8851.c:(.text+0x7d2ee): undefined reference to `crc32_le'
> ks8851.c:(.text+0x7d2f5): undefined reference to `bitrev32'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-19 19:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090818184215.fdf1c7ae.sfr@canb.auug.org.au>
2009-08-18 22:27 ` [PATCH -next] net: fix ks8851 build errors Randy Dunlap
2009-08-19 3:12 ` David Miller
2009-08-19 15:52 ` [PATCH v2] " Randy Dunlap
2009-08-19 19:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).