From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 1/3] qlge: Move TX completion processing to send path.
Date: Thu, 20 Aug 2009 02:18:54 -0700 (PDT) [thread overview]
Message-ID: <20090820.021854.254431313.davem@davemloft.net> (raw)
In-Reply-To: <1250725991-7155-2-git-send-email-ron.mercer@qlogic.com>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Wed, 19 Aug 2009 16:53:09 -0700
> @@ -1205,6 +1205,7 @@ struct bq_desc {
> };
>
> #define QL_TXQ_IDX(qdev, skb) (smp_processor_id()%(qdev->tx_ring_count))
> +#define TXQ_CLEAN_TIME (HZ/4)
>
> struct tx_ring {
> /*
Running this every 1/4 of a second, even when no TX activity is
happening, is very bad for power management.
And starting the timer in response to whether there are TX queue
entries active or not will add overhead and races.
This really isn't workable.
I really and truly believe that the best place for this is in NAPI
context. So bring back the MSI-X vector for TX completions, and
make it schedule a NAPI poll.
next prev parent reply other threads:[~2009-08-20 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 23:53 [net-next PATCH 0/3] qlge: Change RSS ring to MSIx vector mapping Ron Mercer
2009-08-19 23:53 ` [net-next PATCH 1/3] qlge: Move TX completion processing to send path Ron Mercer
2009-08-20 9:18 ` David Miller [this message]
2009-08-21 17:23 ` Ron Mercer
2009-08-21 20:25 ` David Miller
2009-08-19 23:53 ` [net-next PATCH 2/3] qlge: Change RSS ring to MSIx vector mapping Ron Mercer
2009-08-19 23:53 ` [net-next PATCH 3/3] qlge: Remove unused workers and irq handler Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820.021854.254431313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox