From: Ajit Khaparde <ajitk@serverengines.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: davem@davemloft.net, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH][v4] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file.
Date: Thu, 20 Aug 2009 23:14:37 +0530 [thread overview]
Message-ID: <20090820174436.GA21040@serverengines.com> (raw)
In-Reply-To: <1250789072.2779.1.camel@achroite>
On 20/08/09 18:24 +0100, Ben Hutchings wrote:
> On Thu, 2009-08-20 at 22:46 +0530, Ajit Khaparde wrote:
> [...]
> > @@ -489,6 +501,7 @@ struct ethtool_ops {
> > int (*get_stats_count)(struct net_device *);/* use get_sset_count */
> > int (*get_rxnfc)(struct net_device *, struct ethtool_rxnfc *, void *);
> > int (*set_rxnfc)(struct net_device *, struct ethtool_rxnfc *);
> > + int (*flash_device)(struct net_device *, u8 *);
> [...]
>
> The second parameter type should be struct ethtool_flash * not u8 *.
> The compiler warning should make this easy to spot...
Thanks for the catch. My bad. To get over my slow net connection today, I did
a make with the -j option, before I cut the patch. I missed the
warning between the other messages.
Thanks
-Ajit
>
> Ben.
>
> --
> Ben Hutchings, Senior Software Engineer, Solarflare Communications
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-08-20 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 17:16 [RFC][PATCH][v4] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file Ajit Khaparde
2009-08-20 17:24 ` Ben Hutchings
2009-08-20 17:44 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820174436.GA21040@serverengines.com \
--to=ajitk@serverengines.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).