From: David Miller <davem@davemloft.net>
To: richard.rojfors.ext@mocean-labs.com
Cc: andi@lisas.de, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix Micrel KSZ8842 Kconfig description
Date: Sun, 23 Aug 2009 19:49:44 -0700 (PDT) [thread overview]
Message-ID: <20090823.194944.212844649.davem@davemloft.net> (raw)
In-Reply-To: <4A8E9BD3.1040107@mocean-labs.com>
From: Richard Röjfors <richard.rojfors.ext@mocean-labs.com>
Date: Fri, 21 Aug 2009 15:06:27 +0200
> Andreas Mohr wrote:
>> Hi,
>> On Fri, Aug 21, 2009 at 12:36:49PM +0200, Richard Röjfors wrote:
>>> Andreas Mohr wrote:
>>>> Hi,
>>>>
>>>> when doing a "make oldconfig" recently, non-descriptive item "Micrel
>>>> KSZ8842"
>>>> came up, and when I hit "?" to get more info, all I got was a
>>>> tight-lipped
>>>> "This platform driver is for Micrel KSZ8842 chip.".
>>> I see your pain
>> Thanks, and very fast reply too :)
>>
>>> Remove "PCI-based"
>>>
>>> This is a platform device, it is not PCI based.
>>> The KS8842 can sit behind PCI, ISA or VLB, this driver basically
>>> supports the ISA mappings.
>>>
>>> --Richard
>> OK, I had added that because manufacturer specifications seemed to
>> suggest
>> PCI use only. "platform device" should have been a warning sign I
>> guess...
>> Signed-off-by: Andreas Mohr <andi@lisas.de>
>
> Looks good to me
>
> Acked-by: Richard Röjfors <richard.rojfors.ext@mocean-labs.com>
Applied, thanks everyone.
prev parent reply other threads:[~2009-08-24 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 10:20 [PATCH] Fix Micrel KSZ8842 Kconfig description Andreas Mohr
2009-08-21 10:36 ` Richard Röjfors
2009-08-21 10:46 ` Andreas Mohr
2009-08-21 13:06 ` Richard Röjfors
2009-08-24 2:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090823.194944.212844649.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@lisas.de \
--cc=netdev@vger.kernel.org \
--cc=richard.rojfors.ext@mocean-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).