From: Aviv Greenberg <avivgnet@gmail.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Walt Holman <walt@holmansrus.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Strange network timeouts w/ 2.6.30.5
Date: Sun, 23 Aug 2009 22:18:08 +0300 [thread overview]
Message-ID: <20090823191808.GA29972@linux-gec2.site> (raw)
In-Reply-To: <m3skfmk39q.fsf@intrepid.localdomain>
On Thu, Aug 20, 2009 at 03:45:21PM +0200, Krzysztof Halasa wrote:
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 014dfb6..b610088 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -1762,9 +1762,12 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
>
> if (ioread8(&nic->csr->scb.status) & rus_no_res)
> nic->ru_running = RU_SUSPENDED;
> +#ifndef CONFIG_X86
> + /* FIXME interferes with swiotlb. */
> pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
> sizeof(struct rfd),
> PCI_DMA_BIDIRECTIONAL);
> +#endif
> return -ENODATA;
> }
>
> --
Why do you use PCI_DMA_BIDIRECTIONAL? From what i get, the device writes and the
cpu reads - so the direction should be PCI_DMA_FROMDEVICE. Maybe just maybe the
bi-directionality bites you in the swiotlb case.
> Krzysztof Halasa
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-08-23 19:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359163732.51250769223038.JavaMail.root@mail.holmansrus.com>
2009-08-20 11:54 ` Strange network timeouts w/ 2.6.30.5 Walt Holman
2009-08-20 13:45 ` Krzysztof Halasa
2009-08-20 19:28 ` David Miller
2009-08-20 20:28 ` Krzysztof Halasa
2009-08-20 22:21 ` Walt Holman
2009-08-21 9:44 ` Krzysztof Halasa
2009-08-23 19:18 ` Aviv Greenberg [this message]
2009-08-23 20:02 ` Krzysztof Halasa
[not found] <1489093361.01250869377567.JavaMail.root@mail.holmansrus.com>
2009-08-21 15:45 ` Walt Holman
2009-08-22 20:26 ` Krzysztof Halasa
[not found] <1762204735.01250727555803.JavaMail.root@mail.holmansrus.com>
[not found] ` <2087985663.21250727676944.JavaMail.root@mail.holmansrus.com>
2009-08-20 4:17 ` David Miller
2009-08-20 9:03 ` Krzysztof Halasa
2009-08-20 9:13 ` David Miller
2009-08-20 9:22 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090823191808.GA29972@linux-gec2.site \
--to=avivgnet@gmail.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=walt@holmansrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).