From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/2]: pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer
Date: Thu, 27 Aug 2009 08:36:41 +0000 [thread overview]
Message-ID: <20090827083640.GA11152@ff.dom.local> (raw)
In-Reply-To: <20090821.170330.217935645.davem@davemloft.net>
On 22-08-2009 02:03, David Miller wrote:
> None of this stuff should execute in hw IRQ context, therefore
> use a tasklet_hrtimer so that it runs in softirq context.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
...
> void qdisc_watchdog_cancel(struct qdisc_watchdog *wd)
> {
> - hrtimer_cancel(&wd->timer);
> + tasklet_hrtimer_cancel(&wd->timer);
> wd->qdisc->flags &= ~TCQ_F_THROTTLED;
> }
> EXPORT_SYMBOL(qdisc_watchdog_cancel);
I've had a second look at it and I wonder why it's not reported, but
since qdisc_watchdog_cancel is run in qdisc_reset with BHs disabled
it seems there should be (at least) a warning triggered in
tasklet_kill on positive in_interrupt test (unless I miss something,
but can't test it now).
Jarek P.
next prev parent reply other threads:[~2009-08-27 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 0:03 [PATCH 1/2]: pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer David Miller
2009-08-22 8:41 ` Thomas Gleixner
2009-08-23 1:08 ` David Miller
2009-08-22 12:04 ` Jarek Poplawski
2009-08-23 0:54 ` David Miller
2009-08-27 8:36 ` Jarek Poplawski [this message]
2009-09-01 22:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090827083640.GA11152@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).