From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: themann@de.ibm.com, raisch@de.ibm.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH][net-next] LRO: improve aggregation in case of zero TSecr packets
Date: Sun, 30 Aug 2009 22:11:05 -0700 (PDT) [thread overview]
Message-ID: <20090830.221105.37473168.davem@davemloft.net> (raw)
In-Reply-To: <200908270208.31581.opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Thu, 27 Aug 2009 02:08:31 +0300
> This fixes a temporary performance issue we noticed in back to back
> TSO - LRO tests when such tests are run within five minutes after
> boot.
>
> The TSval field of TCP packets is filled in based on the current
> jiffie, which is initialized at -300*HZ. That means that in 5 minutes
> after reboot it will wrap to zero.
RFC1323 says we absolutely must ignore zero TSecr values.
It is a bug that the stack emits a zero value when it means to give a
real TSecr value that will be used.
Probably we can do something like emit '1' when we would emit '0'
based upon jiffies.
And this would be an improvement from now in that having a off-by-one
TSecr in this situation is better than emitting one which we can
guarentee will be ignored.
next prev parent reply other threads:[~2009-08-31 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 23:08 [PATCH][net-next] LRO: improve aggregation in case of zero TSecr packets Octavian Purdila
2009-08-31 5:11 ` David Miller [this message]
2009-08-31 17:15 ` Octavian Purdila
2009-09-25 21:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090830.221105.37473168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox