netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: convert one non-symbolic return value in dev_queue_xmit
@ 2009-08-30  6:21 Krishna Kumar
  2009-08-31  5:18 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Krishna Kumar @ 2009-08-30  6:21 UTC (permalink / raw)
  To: davem; +Cc: netdev, Krishna Kumar

From: Krishna Kumar <krkumar2@in.ibm.com>

net: convert remaining non-symbolic return values in dev_queue_xmit

Patch compiled and 32 simultaneous netperf testing ran fine. 

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---

 net/core/dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff -ruNp org/net/core/dev.c new/net/core/dev.c
--- org/net/core/dev.c	2009-08-28 21:36:46.000000000 +0530
+++ new/net/core/dev.c	2009-08-28 21:40:36.000000000 +0530
@@ -1917,7 +1917,7 @@ gso:
 			HARD_TX_LOCK(dev, txq, cpu);
 
 			if (!netif_tx_queue_stopped(txq)) {
-				rc = 0;
+				rc = NET_XMIT_SUCCESS;
 				if (!dev_hard_start_xmit(skb, dev, txq)) {
 					HARD_TX_UNLOCK(dev, txq);
 					goto out;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: convert one non-symbolic return value in dev_queue_xmit
  2009-08-30  6:21 [PATCH] net: convert one non-symbolic return value in dev_queue_xmit Krishna Kumar
@ 2009-08-31  5:18 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-31  5:18 UTC (permalink / raw)
  To: krkumar2; +Cc: netdev

From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Sun, 30 Aug 2009 11:51:36 +0530

> From: Krishna Kumar <krkumar2@in.ibm.com>
> 
> net: convert remaining non-symbolic return values in dev_queue_xmit
> 
> Patch compiled and 32 simultaneous netperf testing ran fine. 
> 
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>

Applied, but please do me a favor.

Do not provide two commit message header lines like this.
They aren't even equal.

Whatever you give me in the Subject line after "[....] " is what
ends up being the commit message header line when I apply your
patch.

Adding another commit header line in your email message body just
makes the commit look confusing and ugly.

So just give me one in the subject line and elide the one in the
message body.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-31  5:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-30  6:21 [PATCH] net: convert one non-symbolic return value in dev_queue_xmit Krishna Kumar
2009-08-31  5:18 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).