From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: eric.dumazet@gmail.com, xiaoguangrong@cn.fujitsu.com,
yjwei@cn.fujitsu.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] drop_monitor: fix trace_napi_poll_hit()
Date: Mon, 31 Aug 2009 04:47:06 -0700 (PDT) [thread overview]
Message-ID: <20090831.044706.230442890.davem@davemloft.net> (raw)
In-Reply-To: <20090831111245.GA2105@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 31 Aug 2009 07:12:46 -0400
> If its not going to be consistently updated, why are still carrying
> that field in dev? Are we just waiting on someone to do the
> janitorial work to remove it? If so, I can, and I'll fix up the
> drop monitor in the process, to use a private timestamp.
It's used only for bonding, so we only update it when a device
receives packet as part of a bond.
%99.9999 of people are not in that situation, and in that case this is
a very wasteful and expensive cacheline dirtying, so we elide it when
we can.
next prev parent reply other threads:[~2009-08-31 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 6:10 [PATCH resend] drop_monitor: fix trace_napi_poll_hit() Xiao Guangrong
2009-08-31 6:31 ` Eric Dumazet
2009-08-31 11:12 ` Neil Horman
2009-08-31 11:47 ` David Miller [this message]
2009-08-31 13:33 ` Eric Dumazet
2009-08-31 15:42 ` Neil Horman
2009-08-31 16:34 ` [PATCH net-next-2.6] drivers: Kill now superfluous ->last_rx stores Eric Dumazet
2009-08-31 17:37 ` Neil Horman
2009-09-03 6:09 ` David Miller
2009-09-02 1:20 ` [PATCH resend] drop_monitor: fix trace_napi_poll_hit() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831.044706.230442890.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).