Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: damian@tvk.rwth-aachen.de, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert Backoff [v3]: Rename skb to icmp_skb in tcp_v4_err()
Date: Mon, 31 Aug 2009 06:34:35 -0700 (PDT)	[thread overview]
Message-ID: <20090831.063435.190660445.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.00.0908311538050.29341@wel-95.cs.helsinki.fi>

From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 31 Aug 2009 16:22:58 +0300 (EEST)

> Not that related to the purpose of this patch but still worth to
> mention now that we are in the context... ...I wonder if this should
> be pskb_may_pull instead of direct compare here regardless of this
> change?

ICMP layer that invokes this code makes sure enough headers
are in the linear area already.

> Acked-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Thanks for reviewing.

      reply	other threads:[~2009-08-31 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 10:16 [PATCH 1/3] Revert Backoff [v3]: Rename skb to icmp_skb in tcp_v4_err() Damian Lukowski
2009-08-31 13:22 ` Ilpo Järvinen
2009-08-31 13:34   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090831.063435.190660445.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=damian@tvk.rwth-aachen.de \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox