From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: mikem@ring3k.org, netdev@vger.kernel.org,
rene.mayrhofer@gibraltar.at, leitner@esys.at
Subject: Re: [PATCH] sky2: fix management of driver LED
Date: Tue, 1 Sep 2009 21:33:25 -0700 [thread overview]
Message-ID: <20090901213325.69b3348b@nehalam> (raw)
In-Reply-To: <20090901.174437.145971351.davem@davemloft.net>
On Tue, 01 Sep 2009 17:44:37 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Mon, 31 Aug 2009 10:31:41 -0700
>
> > Observed by Mike McCormack.
> >
> > The LED bit here is just a software controlled value used to
> > turn on one of the LED's on some boards. The register value was wrong,
> > which could have been causing some power control issues.
> > Get rid of problematic define use the correct mask.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Applied.
If these power management fixes do fix all the reported problems,
then I will consider back porting (probably to 2.6.31.1).
--
next prev parent reply other threads:[~2009-09-02 4:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 13:10 [PATCH] sky2: Don't try to turn led off in sky2_down() Mike McCormack
2009-08-29 13:17 ` Mike McCormack
2009-08-29 17:57 ` Stephen Hemminger
2009-08-30 0:37 ` Mike McCormack
2009-08-31 9:48 ` Rene Mayrhofer
2009-08-31 9:58 ` Rene Mayrhofer
2009-09-03 16:16 ` [PATCH] sky2: only enable Vaux if capable of wakeup Stephen Hemminger
2009-09-04 3:10 ` David Miller
2009-09-04 11:55 ` Rene Mayrhofer
2009-08-31 17:31 ` [PATCH] sky2: fix management of driver LED Stephen Hemminger
2009-09-02 0:44 ` David Miller
2009-09-02 4:33 ` Stephen Hemminger [this message]
2009-09-02 7:28 ` Rene Mayrhofer
2009-09-02 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901213325.69b3348b@nehalam \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=leitner@esys.at \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=rene.mayrhofer@gibraltar.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).