From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] sky2: fix management of driver LED Date: Wed, 02 Sep 2009 00:33:57 -0700 (PDT) Message-ID: <20090902.003357.176916678.davem@davemloft.net> References: <20090831103141.77598705@nehalam> <20090901.174437.145971351.davem@davemloft.net> <20090901213325.69b3348b@nehalam> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mikem@ring3k.org, netdev@vger.kernel.org, rene.mayrhofer@gibraltar.at, leitner@esys.at To: shemminger@linux-foundation.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41736 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203AbZIBHdm (ORCPT ); Wed, 2 Sep 2009 03:33:42 -0400 In-Reply-To: <20090901213325.69b3348b@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: From: Stephen Hemminger Date: Tue, 1 Sep 2009 21:33:25 -0700 > On Tue, 01 Sep 2009 17:44:37 -0700 (PDT) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Mon, 31 Aug 2009 10:31:41 -0700 >> >> > Observed by Mike McCormack. >> > >> > The LED bit here is just a software controlled value used to >> > turn on one of the LED's on some boards. The register value was wrong, >> > which could have been causing some power control issues. >> > Get rid of problematic define use the correct mask. >> > >> > Signed-off-by: Stephen Hemminger >> >> Applied. > > If these power management fixes do fix all the reported problems, > then I will consider back porting (probably to 2.6.31.1). Good idea.