From: David Miller <davem@davemloft.net>
To: jgarzik@pobox.com
Cc: ajitk@serverengines.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file.
Date: Wed, 02 Sep 2009 22:43:59 -0700 (PDT) [thread overview]
Message-ID: <20090902.224359.256829926.davem@davemloft.net> (raw)
In-Reply-To: <4A9F550D.1090105@pobox.com>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 03 Sep 2009 01:33:01 -0400
> It passes a _filepath_ directly into the kernel? That seems quite
> wrong...
>
> we fixed kernel drivers to _not_ think they could read directly from
> the userland filesystem many years ago.
>
> Seems like passing in an mmap'd fd would be far preferable.
Jeff, it's passing in something that's going to requested via
the firmware loading infrastructure in the kernel.
It is the most appropriate way to do this.
next prev parent reply other threads:[~2009-09-03 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 3:02 [PATCH net-next-2.6] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file Ajit Khaparde
2009-09-03 5:33 ` Jeff Garzik
2009-09-03 5:43 ` David Miller [this message]
2009-09-03 5:55 ` Jeff Garzik
2009-09-03 6:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902.224359.256829926.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).