From: David Miller <davem@davemloft.net>
To: gerg@snapgear.com
Cc: u.kleine-koenig@pengutronix.de, linux-rt-users@vger.kernel.org,
ben@decadent.org.uk, kaber@trash.net, s.hauer@pengutronix.de,
Matt.Waddel@freescale.com, netdev@vger.kernel.org,
tim01@vlsi.informatik.tu-darmstadt.de
Subject: Re: [PATCH 1/2] fec: fix recursive locking of mii_lock
Date: Wed, 02 Sep 2009 23:17:01 -0700 (PDT) [thread overview]
Message-ID: <20090902.231701.09584427.davem@davemloft.net> (raw)
In-Reply-To: <4A9F18E0.3060307@snapgear.com>
From: Greg Ungerer <gerg@snapgear.com>
Date: Thu, 03 Sep 2009 11:16:16 +1000
> Hi Uwe,
>
> Uwe Kleine-König wrote:
>> mii_discover_phy is only called by fec_enet_mii (via mip->mii_func).
>> So
>> &fep->mii_lock is already held and mii_discover_phy must not call
>> mii_queue which locks &fep->mii_lock, too.
>> This was noticed by lockdep:
...
>> ...
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Cc: Greg Ungerer <gerg@uclinux.org>
>
> Looks good too.
>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-09-03 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200908311143.08952.tim01@vlsi.informatik.tu-darmstadt.de>
2009-08-31 13:22 ` Latest PreemptRT patch error on imx35 Uwe Kleine-König
2009-08-31 15:29 ` Tim Sander
2009-08-31 16:37 ` [PATCH] " Tim Sander
2009-09-02 9:14 ` [PATCH 1/2] fec: fix recursive locking of mii_lock Uwe Kleine-König
2009-09-02 9:14 ` [PATCH 2/2] fec: don't enable irqs in hard irq context Uwe Kleine-König
2009-09-03 1:14 ` Greg Ungerer
2009-09-03 6:17 ` David Miller
2009-09-03 1:16 ` [PATCH 1/2] fec: fix recursive locking of mii_lock Greg Ungerer
2009-09-03 6:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902.231701.09584427.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matt.Waddel@freescale.com \
--cc=ben@decadent.org.uk \
--cc=gerg@snapgear.com \
--cc=kaber@trash.net \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tim01@vlsi.informatik.tu-darmstadt.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).