From: David Miller <davem@davemloft.net>
To: chas@cmf.nrl.navy.mil
Cc: netdev@vger.kernel.org, karl@hiramoto.org
Subject: Re: [PATCH] atm/br2684: netif_stop_queue() when atm device busy and netif_wake_queue() when we can send packets again.
Date: Wed, 02 Sep 2009 23:27:07 -0700 (PDT) [thread overview]
Message-ID: <20090902.232707.93089975.davem@davemloft.net> (raw)
In-Reply-To: <200908311429.n7VETlTi000764@cmf.nrl.navy.mil>
From: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
Date: Mon, 31 Aug 2009 10:29:47 -0400
> This patch removes the call to dev_kfree_skb() when the atm device is busy.
> Calling dev_kfree_skb() causes heavy packet loss then the device is under
> heavy load, the more correct behavior should be to stop the upper layers,
> then when the lower device can queue packets again wake the upper layers.
>
> Signed-off-by: Karl Hiramoto <karl@hiramoto.org>
> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Applied to net-next-2.6, but Chas your email client corrupted
the patch by breaking up long lines:
> @@ -142,6 +142,22 @@ static struct net_device *br2684_find_dev(const struct br
> 2684_if_spec *s)
Like that.
next prev parent reply other threads:[~2009-09-03 6:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 10:38 [PATCH] br2684 testing needed for packet loss and performance Karl Hiramoto
2009-08-28 12:25 ` [Linux-ATM-General] " Chas Williams (CONTRACTOR)
2009-08-29 10:24 ` Karl Hiramoto
2009-08-29 11:24 ` [PATCH] atm/br2684: netif_stop_queue() when atm device busy and netif_wake_queue() when we can send packets again Karl Hiramoto
2009-08-31 14:29 ` Chas Williams (CONTRACTOR)
2009-09-03 6:27 ` David Miller [this message]
2009-09-03 13:44 ` Chas Williams (CONTRACTOR)
2009-09-10 19:49 ` [Linux-ATM-General] " Philip A. Prindeville
2009-09-10 21:30 ` Karl Hiramoto
2009-09-11 18:48 ` David Miller
2009-09-15 13:44 ` Karl Hiramoto
2009-09-15 14:57 ` Karl Hiramoto
2009-09-16 18:04 ` Philip A. Prindeville
2009-09-11 19:56 ` Philip A. Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902.232707.93089975.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=karl@hiramoto.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).