From: David Miller <davem@davemloft.net>
To: cratiu@ixiacom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: Fix tcp_v6_send_response(): it didn't set skb transport header
Date: Thu, 03 Sep 2009 20:45:10 -0700 (PDT) [thread overview]
Message-ID: <20090903.204510.170648802.davem@davemloft.net> (raw)
In-Reply-To: <200909031925.54197.cratiu@ixiacom.com>
From: Cosmin Ratiu <cratiu@ixiacom.com>
Date: Thu, 3 Sep 2009 19:25:53 +0300
> Hello,
>
> Here is a patch which fixes an issue observed when using TCP over IPv6 and AH
> from IPsec.
>
> When a connection gets closed the 4-way method and the last ACK from the
> server gets dropped, the subsequent FINs from the client do not get ACKed
> because tcp_v6_send_response does not set the transport header pointer. This
> causes ah6_output to try to allocate a lot of memory, which typically fails,
> so the ACKs never make it out of the stack.
>
> I have reproduced the problem on kernel 2.6.7, but after looking at the latest
> kernel it seems the problem is still there.
>
> Signed-off-by: Cosmin Ratiu <cratiu@ixiacom.com>
Great catch. IPV4 handles this transparently via ip_append_data()
which is what it uses to send these kinds of frames. IPV6 does
this stuff by hand.
Applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-09-04 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 16:25 [PATCH] ipv6: Fix tcp_v6_send_response(): it didn't set skb transport header Cosmin Ratiu
2009-09-04 3:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903.204510.170648802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cratiu@ixiacom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).