From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Rene Mayrhofer <rene.mayrhofer@gibraltar.at>,
David Miller <davem@davemloft.net>
Cc: Mike McCormack <mikem@ring3k.org>,
netdev@vger.kernel.org, Richard Leitner <leitner@esys.at>
Subject: [PATCH] sky2: only enable Vaux if capable of wakeup
Date: Thu, 3 Sep 2009 09:16:25 -0700 [thread overview]
Message-ID: <20090903091625.2e6aff91@nehalam> (raw)
In-Reply-To: <200908311158.57972.rene.mayrhofer@gibraltar.at>
While perusing vendor driver, I saw that it did not enable the Vaux
power unless device was able to wake from lan for D3cold.
This might help for Rene's power issue.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2009-09-03 09:01:24.668473584 -0700
+++ b/drivers/net/sky2.c 2009-09-03 09:10:18.949088574 -0700
@@ -272,8 +272,9 @@ static void sky2_power_aux(struct sky2_h
Y2_CLK_GAT_LNK1_DIS | Y2_PCI_CLK_LNK2_DIS |
Y2_COR_CLK_LNK2_DIS | Y2_CLK_GAT_LNK2_DIS);
- /* switch power to VAUX */
- if (sky2_read32(hw, B0_CTST) & Y2_VAUX_AVAIL)
+ /* switch power to VAUX if supported and PME from D3cold */
+ if ( (sky2_read32(hw, B0_CTST) & Y2_VAUX_AVAIL) &&
+ pci_pme_capable(hw->pdev, PCI_D3cold))
sky2_write8(hw, B0_POWER_CTRL,
(PC_VAUX_ENA | PC_VCC_ENA |
PC_VAUX_ON | PC_VCC_OFF));
next prev parent reply other threads:[~2009-09-03 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 13:10 [PATCH] sky2: Don't try to turn led off in sky2_down() Mike McCormack
2009-08-29 13:17 ` Mike McCormack
2009-08-29 17:57 ` Stephen Hemminger
2009-08-30 0:37 ` Mike McCormack
2009-08-31 9:48 ` Rene Mayrhofer
2009-08-31 9:58 ` Rene Mayrhofer
2009-09-03 16:16 ` Stephen Hemminger [this message]
2009-09-04 3:10 ` [PATCH] sky2: only enable Vaux if capable of wakeup David Miller
2009-09-04 11:55 ` Rene Mayrhofer
2009-08-31 17:31 ` [PATCH] sky2: fix management of driver LED Stephen Hemminger
2009-09-02 0:44 ` David Miller
2009-09-02 4:33 ` Stephen Hemminger
2009-09-02 7:28 ` Rene Mayrhofer
2009-09-02 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903091625.2e6aff91@nehalam \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=leitner@esys.at \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=rene.mayrhofer@gibraltar.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).