From: Stephen Hemminger <shemminger@vyatta.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: David Miller <davem@davemloft.net>,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] wan: dlci/sdla transmit return dehacking
Date: Fri, 4 Sep 2009 19:38:10 -0700 [thread overview]
Message-ID: <20090904193810.46543e3c@nehalam> (raw)
In-Reply-To: <m31vmmk0kt.fsf@intrepid.localdomain>
On Fri, 04 Sep 2009 20:48:50 +0200
Krzysztof Halasa <khc@pm.waw.pl> wrote:
> Stephen Hemminger <shemminger@vyatta.com> writes:
>
> > This is a brute force removal of the wierd slave interface done for
> > DLCI -> SDLA transmit. Before it was using non-standard return values
> > and freeing skb in caller. This changes it to using normal return
> > values, and freeing in the callee. Luckly only one driver pair was
> > doing this. Not tested on real hardware, in fact I wonder if this
> > driver pair is even being used by any users.
>
> The only hardware which seems to be driven by dlci.c is sdla.c =
> old Sangoma ISA cards.
>
> Sangoma seems to maintain their own drivers for their hw (including
> these ISA cards).
>
> Are the in-kernel drivers functional after all those years? I don't
> know.
In the Vyatta product we use the Sangoma drivers, so we actually have
to make and not configure in the existing WAN drivers.
--
next prev parent reply other threads:[~2009-09-05 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 4:34 linux-next: net tree build warnings Stephen Rothwell
2009-09-04 4:35 ` David Miller
2009-09-04 15:33 ` [PATCH net-next] wan: dlci/sdla transmit return dehacking Stephen Hemminger
2009-09-04 18:48 ` Krzysztof Halasa
2009-09-05 2:38 ` Stephen Hemminger [this message]
2009-09-05 11:09 ` Krzysztof Halasa
2009-09-07 8:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904193810.46543e3c@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).