netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/12] Gigaset driver patches for 2.6.32
@ 2009-09-06 18:58 Tilman Schmidt
  2009-09-06 18:58 ` [PATCH 09/12] gigaset: add kerneldoc comments Tilman Schmidt
                   ` (8 more replies)
  0 siblings, 9 replies; 25+ messages in thread
From: Tilman Schmidt @ 2009-09-06 18:58 UTC (permalink / raw)
  To: davem, linux-kernel, netdev, i4ldeveloper; +Cc: Hansjoerg Lipp

Dave,

following is a series of patches for the Gigaset driver which I would
appreciate getting merged into kernel release 2.6.32.

The first one is a bugfix I had already submitted for 2.6.31 but which
seems to have fallen through the cracks. Please disregard if it's
already present your tree.

The next eight patches provide various small bugfixes, error handling
and documentation improvements.

The final three patches add an alternative interface to the driver,
connecting to the Kernel CAPI subsystem instead of the obsolescent
ISDN4Linux subsystem. They have been presented on the i4ldeveloper
mailing list and didn't draw any protests. (In fact, no comments at
all. I'm determined to take that as a positive sign.)

Would you please take these into your net tree for 2.6.32.

Thanks,
Tilman

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 00/12] Gigaset driver patches for 2.6.32
@ 2009-09-09 22:32 Tilman Schmidt
  0 siblings, 0 replies; 25+ messages in thread
From: Tilman Schmidt @ 2009-09-09 22:32 UTC (permalink / raw)
  To: Daniel Walker
  Cc: i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp,
	netdev-u79uwXL29TY76Z2rM5mHXA, Hansjoerg Lipp,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q, linux-kernel-u79uwXL29TY76Z2rM5mHXA

Daniel Walker wrote 07.09.09 16:30:
> Yeah, it looks like the whole file needs a checkpatch clean up.. Sounds
like your not willing to do that?

It's not a question of willingness. You may notice I did a lot of cleanup work already. But it's very time consuming work, and there has been more important work to attend to first.

> Usually if a checkpatch cleanup comes
first prior to all your other changes , it doesn't usually cloud the
rest of the changes..

Sure. But that would mean postponing the merging of bugfixes until someone finds the time to do a complete checkpatch cleanup of the affected code. I don't think that's a sensible approach.

Thanks,
Tilman

^ permalink raw reply	[flat|nested] 25+ messages in thread
[parent not found: <20090909223205.E9D632269516@fifo99.com>]
* Re: [PATCH 00/12] Gigaset driver patches for 2.6.32
@ 2009-09-10 14:05 Tilman Schmidt
  0 siblings, 0 replies; 25+ messages in thread
From: Tilman Schmidt @ 2009-09-10 14:05 UTC (permalink / raw)
  To: David Miller, dwalker-zu3NM2574RrQT0dZR+AlfA
  Cc: hjlipp-S0/GAf8tV78, netdev-u79uwXL29TY76Z2rM5mHXA,
	tilman-ZTO5kqT2PaM, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp

Von: "David Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
An: dwalker-zu3NM2574RrQT0dZR+AlfA@public.gmane.org
Cc: tilman-ZTO5kqT2PaM@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org; hjlipp-S0/GAf8tV78@public.gmane.org
Gesendet: 10.09.09 05:51
Betreff: Re: [PATCH 00/12] Gigaset driver patches for 2.6.32

> From: Daniel Walker <dwalker-zu3NM2574RrQT0dZR+AlfA@public.gmane.org>
> Date: Wed, 09 Sep 2009 20:47:57 -0700

> On Thu, 2009-09-10 at 00:32 +0200, Tilman Schmidt wrote:
>> Daniel Walker wrote 07.09.09 16:30:
>> > Yeah, it looks like the whole file needs a checkpatch clean up..
>> Sounds
>> like your not willing to do that?
>> 
>> It's not a question of willingness. You may notice I did a lot of
>> cleanup work already. But it's very time consuming work, and there has
>> been more important work to attend to first.
>> 
>> > Usually if a checkpatch cleanup comes
>> first prior to all your other changes , it doesn't usually cloud the
>> rest of the changes..
>> 
>> Sure. But that would mean postponing the merging of bugfixes until
>> someone finds the time to do a complete checkpatch cleanup of the
>> affected code. I don't think that's a sensible approach.
> 
> You shouldn't be adding any new checkpatch errors, but you currently
> are .. Just clean up the individual patches w/o the entire gigaset
> driver, that should be do-able (it's even a basic submission
> requirement). The other issue is that your adding new files which aren't
> clean, those can certainly be cleaned up.

> Right, this is a very reasonable request.

Then so be it. Will do as soon as time permits.

T.

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2009-09-10 14:05 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-06 18:58 [PATCH 00/12] Gigaset driver patches for 2.6.32 Tilman Schmidt
2009-09-06 18:58 ` [PATCH 09/12] gigaset: add kerneldoc comments Tilman Schmidt
2009-09-06 18:58 ` [PATCH 11/12] gigaset: allow building without I4L Tilman Schmidt
2009-09-06 18:58 ` [PATCH 01/12] gigaset: really fix chars_in_buffer Tilman Schmidt
2009-09-06 18:58 ` [PATCH 05/12] gigaset: announce if built with debugging Tilman Schmidt
     [not found] ` <20090906-patch-gigaset-00.tilman-ZTO5kqT2PaM@public.gmane.org>
2009-09-06 18:58   ` [PATCH 12/12] gigaset: add Kernel CAPI interface Tilman Schmidt
2009-09-06 18:58   ` [PATCH 03/12] gigaset: linearize skb Tilman Schmidt
2009-09-06 18:58   ` [PATCH 04/12] gigaset: handle isoc frame errors more gracefully Tilman Schmidt
2009-09-06 18:58   ` [PATCH 08/12] gigaset: correct debugging output selection Tilman Schmidt
2009-09-06 18:58   ` [PATCH 07/12] gigaset: improve error recovery Tilman Schmidt
     [not found]     ` <20090906-patch-gigaset-07.tilman-ZTO5kqT2PaM@public.gmane.org>
2009-09-07  8:59       ` [PATCH 07/12 v2] " Tilman Schmidt
2009-09-06 18:58   ` [PATCH 10/12] gigaset: prepare for CAPI implementation Tilman Schmidt
2009-09-06 18:58 ` [PATCH 06/12] gigaset: fix device ERROR response handling Tilman Schmidt
2009-09-06 18:58 ` [PATCH 02/12] gigaset: fix reject/hangup handling Tilman Schmidt
2009-09-07  1:26 ` [PATCH 00/12] Gigaset driver patches for 2.6.32 Daniel Walker
2009-09-07  9:07   ` Tilman Schmidt
2009-09-07 14:30     ` Daniel Walker
2009-09-07  9:00 ` David Miller
2009-09-07  9:11   ` Tilman Schmidt
2009-09-07  9:18     ` David Miller
2009-09-07 18:56       ` Karsten Keil
  -- strict thread matches above, loose matches on Subject: below --
2009-09-09 22:32 Tilman Schmidt
     [not found] <20090909223205.E9D632269516@fifo99.com>
2009-09-10  3:47 ` Daniel Walker
2009-09-10  3:51   ` David Miller
2009-09-10 14:05 Tilman Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).