From: Tilman Schmidt <tilman-ZTO5kqT2PaM@public.gmane.org>
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org
Cc: Hansjoerg Lipp <hjlipp-S0/GAf8tV78@public.gmane.org>
Subject: [PATCH 03/12] gigaset: linearize skb
Date: Sun, 6 Sep 2009 20:58:52 +0200 (CEST) [thread overview]
Message-ID: <20090906-patch-gigaset-03.tilman@imap.cc> (raw)
In-Reply-To: <20090906-patch-gigaset-00.tilman-ZTO5kqT2PaM@public.gmane.org>
The code of the Gigaset driver assumes that sk_buff-s coming
from the ISDN4Linux subsystem are always linear. Explicitly
calling skb_linearize() is cheap if they are, but much more
robust in case they ever aren't.
Impact: robustness improvement
Signed-off-by: Tilman Schmidt <tilman-ZTO5kqT2PaM@public.gmane.org>
---
drivers/isdn/gigaset/i4l.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c
index 9b22f9c..322f16e 100644
--- a/drivers/isdn/gigaset/i4l.c
+++ b/drivers/isdn/gigaset/i4l.c
@@ -51,6 +51,12 @@ static int writebuf_from_LL(int driverID, int channel, int ack,
return -ENODEV;
}
bcs = &cs->bcs[channel];
+
+ /* can only handle linear sk_buffs */
+ if (skb_linearize(skb) < 0) {
+ dev_err(cs->dev, "%s: skb_linearize failed\n", __func__);
+ return -ENOMEM;
+ }
len = skb->len;
gig_dbg(DEBUG_LLDATA,
--
1.6.2.1.214.ge986c
next prev parent reply other threads:[~2009-09-06 18:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 18:58 [PATCH 00/12] Gigaset driver patches for 2.6.32 Tilman Schmidt
2009-09-06 18:58 ` [PATCH 05/12] gigaset: announce if built with debugging Tilman Schmidt
2009-09-06 18:58 ` [PATCH 11/12] gigaset: allow building without I4L Tilman Schmidt
[not found] ` <20090906-patch-gigaset-00.tilman-ZTO5kqT2PaM@public.gmane.org>
2009-09-06 18:58 ` [PATCH 12/12] gigaset: add Kernel CAPI interface Tilman Schmidt
2009-09-06 18:58 ` [PATCH 04/12] gigaset: handle isoc frame errors more gracefully Tilman Schmidt
2009-09-06 18:58 ` [PATCH 07/12] gigaset: improve error recovery Tilman Schmidt
[not found] ` <20090906-patch-gigaset-07.tilman-ZTO5kqT2PaM@public.gmane.org>
2009-09-07 8:59 ` [PATCH 07/12 v2] " Tilman Schmidt
2009-09-06 18:58 ` [PATCH 10/12] gigaset: prepare for CAPI implementation Tilman Schmidt
2009-09-06 18:58 ` [PATCH 08/12] gigaset: correct debugging output selection Tilman Schmidt
2009-09-06 18:58 ` Tilman Schmidt [this message]
2009-09-06 18:58 ` [PATCH 01/12] gigaset: really fix chars_in_buffer Tilman Schmidt
2009-09-06 18:58 ` [PATCH 06/12] gigaset: fix device ERROR response handling Tilman Schmidt
2009-09-06 18:58 ` [PATCH 02/12] gigaset: fix reject/hangup handling Tilman Schmidt
2009-09-06 18:58 ` [PATCH 09/12] gigaset: add kerneldoc comments Tilman Schmidt
2009-09-07 1:26 ` [PATCH 00/12] Gigaset driver patches for 2.6.32 Daniel Walker
2009-09-07 9:07 ` Tilman Schmidt
2009-09-07 14:30 ` Daniel Walker
2009-09-07 9:00 ` David Miller
2009-09-07 9:11 ` Tilman Schmidt
2009-09-07 9:18 ` David Miller
2009-09-07 18:56 ` Karsten Keil
-- strict thread matches above, loose matches on Subject: below --
2009-09-18 23:57 [PATCH 00/12] Gigaset driver patches for 2.6.32 (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 03/12] gigaset: linearize skb Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906-patch-gigaset-03.tilman@imap.cc \
--to=tilman-zto5kqt2pam@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=hjlipp-S0/GAf8tV78@public.gmane.org \
--cc=i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).