From: Octavian Purdila <opurdila@ixiacom.com>
To: "Ilia K." <mail4ilia@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: multicast routing and multiple interfaces with same IP
Date: Mon, 7 Sep 2009 19:25:16 +0300 [thread overview]
Message-ID: <200909071925.17078.opurdila@ixiacom.com> (raw)
In-Reply-To: <1b9338490909070835t3517bc36o396539e7ea1721fc@mail.gmail.com>
On Monday 07 September 2009 18:35:41 you wrote:
> Hi,
> I'm attaching a new patch. The changes:
> mroute.h:
> - consistent name for interface index: vifc_lcl_ifindex
> - union of vifc_lcl_addr and vifc_lcl_ifindex since either one of them
> can be used
> ipmr.c:
> - case VIFF_USE_IFINDEX and case 0 had almost the same code, so using
> fall through and if to eliminate code duplication
>
Hi Ilia,
Looks good to me, but there are a couple of code style issues reported by
./scripts/checkpatch.pl.
Also, here:
>+ } else {
>+ dev = ip_dev_find(net, vifc->vifc_lcl_addr.s_addr);
>+ }
Usually no braces are used for single line statements in if/else.
tavi
prev parent reply other threads:[~2009-09-07 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 23:26 multicast routing and multiple interfaces with same IP Ilia K.
2009-08-26 23:53 ` Octavian Purdila
2009-08-29 7:01 ` David Miller
2009-09-07 15:35 ` Ilia K.
2009-09-07 16:25 ` Octavian Purdila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909071925.17078.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=davem@davemloft.net \
--cc=mail4ilia@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox