From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org
Subject: Re: net_sched: fix estimator lock selection for mq child qdiscs
Date: Wed, 09 Sep 2009 18:11:42 -0700 (PDT) [thread overview]
Message-ID: <20090909.181142.130068809.davem@davemloft.net> (raw)
In-Reply-To: <4AA7D0C5.9080601@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Wed, 09 Sep 2009 17:59:01 +0200
> net_sched: fix estimator lock selection for mq child qdiscs
>
> When new child qdiscs are attached to the mq qdisc, they are actually
> attached as root qdiscs to the device queues. The lock selection for
> new estimators incorrectly picks the root lock of the existing and
> to be replaced qdisc, which results in a use-after-free once the old
> qdisc has been destroyed.
>
> Mark mq qdisc instances with a new flag and treat qdiscs attached to
> mq as children similar to regular root qdiscs.
>
> Additionally prevent estimators from being attached to the mq qdisc
> itself since it only updates its byte and packet counters during dumps.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied, thanks!
prev parent reply other threads:[~2009-09-10 1:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 15:59 net_sched: fix estimator lock selection for mq child qdiscs Patrick McHardy
2009-09-10 1:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909.181142.130068809.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox