* [PATCH] dm9000: Use resource_size instead of private macro
@ 2009-09-09 11:07 Tobias Klauser
2009-09-09 11:07 ` [PATCH] dm9000: Remove unnecessary memset of netdev private data Tobias Klauser
2009-09-10 1:55 ` [PATCH] dm9000: Use resource_size instead of private macro David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Tobias Klauser @ 2009-09-09 11:07 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Tobias Klauser
The macro res_size in drivers/net/dm9000.c is a copy of resource_size in
linux/ioport.h. Remove the function and use resource_size instead.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/dm9000.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index dd771de..00a9db8 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -1185,8 +1185,6 @@ static const struct net_device_ops dm9000_netdev_ops = {
#endif
};
-#define res_size(_r) (((_r)->end - (_r)->start) + 1)
-
/*
* Search DM9000 board, allocate space and register it
*/
@@ -1236,7 +1234,7 @@ dm9000_probe(struct platform_device *pdev)
goto out;
}
- iosize = res_size(db->addr_res);
+ iosize = resource_size(db->addr_res);
db->addr_req = request_mem_region(db->addr_res->start, iosize,
pdev->name);
@@ -1254,7 +1252,7 @@ dm9000_probe(struct platform_device *pdev)
goto out;
}
- iosize = res_size(db->data_res);
+ iosize = resource_size(db->data_res);
db->data_req = request_mem_region(db->data_res->start, iosize,
pdev->name);
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] dm9000: Remove unnecessary memset of netdev private data
2009-09-09 11:07 [PATCH] dm9000: Use resource_size instead of private macro Tobias Klauser
@ 2009-09-09 11:07 ` Tobias Klauser
2009-09-10 1:55 ` David Miller
2009-09-10 1:55 ` [PATCH] dm9000: Use resource_size instead of private macro David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Tobias Klauser @ 2009-09-09 11:07 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Tobias Klauser
The memory for the private data is allocated using kzalloc in
alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to
set it to 0 again.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/dm9000.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 00a9db8..11995ad 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -1213,7 +1213,6 @@ dm9000_probe(struct platform_device *pdev)
/* setup board info structure */
db = netdev_priv(ndev);
- memset(db, 0, sizeof(*db));
db->dev = &pdev->dev;
db->ndev = ndev;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dm9000: Use resource_size instead of private macro
2009-09-09 11:07 [PATCH] dm9000: Use resource_size instead of private macro Tobias Klauser
2009-09-09 11:07 ` [PATCH] dm9000: Remove unnecessary memset of netdev private data Tobias Klauser
@ 2009-09-10 1:55 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-09-10 1:55 UTC (permalink / raw)
To: tklauser; +Cc: netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Wed, 9 Sep 2009 13:07:43 +0200
> The macro res_size in drivers/net/dm9000.c is a copy of resource_size in
> linux/ioport.h. Remove the function and use resource_size instead.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-10 1:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-09 11:07 [PATCH] dm9000: Use resource_size instead of private macro Tobias Klauser
2009-09-09 11:07 ` [PATCH] dm9000: Remove unnecessary memset of netdev private data Tobias Klauser
2009-09-10 1:55 ` David Miller
2009-09-10 1:55 ` [PATCH] dm9000: Use resource_size instead of private macro David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).