From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: shemminger@vyatta.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, gospo@redhat.com,
gregory.v.rose@intel.com, donald.c.skidmore@intel.com
Subject: Re: [net-next PATCH] igb: Use Intel OUI for VF MAC addresses
Date: Fri, 11 Sep 2009 12:15:42 -0700 (PDT) [thread overview]
Message-ID: <20090911.121542.45333246.davem@davemloft.net> (raw)
In-Reply-To: <1252638163.4355.35.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Thu, 10 Sep 2009 20:02:43 -0700
> On Thu, 2009-09-10 at 19:07 -0700, Stephen Hemminger wrote:
>> On Thu, 10 Sep 2009 18:48:27 -0700
>> Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>> > From: Gregory Rose <gregory.v.rose@intel.com>
>> > This patch changes the default VF MAC address generation to use an Intel
>> > Organizational Unit Identifier (OUI), instead of a fully randomized
>> > Ethernet address. This is to help prevent accidental MAC address
>> > collisions.
>
> I think this not a very good idea.
>
>> How can probability of collision be lower when the address space
>> is smaller? If you are going to use Intel OUI, then you should constrain
>> the selection to a portion of that space that is not being used
>> by other hardware. I.e if you know Intel assigns addresses to their
>> devices in ranges, choose a range that is not in use.
>
> Some other possibilities might be:
I also completely agree that this patch is not a wise move.
next prev parent reply other threads:[~2009-09-11 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 1:48 [net-next PATCH] igb: Use Intel OUI for VF MAC addresses Jeff Kirsher
2009-09-11 2:07 ` Stephen Hemminger
2009-09-11 3:02 ` Joe Perches
2009-09-11 19:15 ` David Miller [this message]
2009-09-11 20:20 ` [net-next PATCH] etherdevice.h: random_ether_addr update Joe Perches
2009-09-11 20:44 ` [net-next PATCH V2] " Joe Perches
2009-09-11 21:13 ` Rose, Gregory V
2009-09-11 21:15 ` [net-next PATCH] " Stephen Hemminger
2009-09-12 0:57 ` Joe Perches
2009-09-13 0:14 ` Mark Smith
2009-09-13 0:33 ` Mark Smith
2009-09-13 0:44 ` Joe Perches
2009-09-13 3:47 ` Mark Smith
2009-09-13 6:09 ` Joe Perches
2009-09-13 6:39 ` Mark Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911.121542.45333246.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).