From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: benli@broadcom.com, netdev@vger.kernel.org
Subject: Re: 5717 support commit is buggy
Date: Fri, 11 Sep 2009 15:41:25 -0700 (PDT) [thread overview]
Message-ID: <20090911.154125.182458823.davem@davemloft.net> (raw)
In-Reply-To: <20090911.151554.181296228.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 11 Sep 2009 15:15:54 -0700 (PDT)
> I'm about to do some tests, but I suspect it's this change:
>
> @@ -111,7 +111,8 @@
> * replace things like '% foo' with '& (foo - 1)'.
> */
> #define TG3_RX_RCB_RING_SIZE(tp) \
> - ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ? 512 : 1024)
> + (((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) && \
> + !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) ? 512 : 1024)
>
> #define TG3_TX_RING_SIZE 512
> #define TG3_DEF_TX_RING_PENDING (TG3_TX_RING_SIZE - 1)
>
> and thus an incorrect RCB ring size is being used which eventually
> locks up the card.
Confirmed, reverting that part of the change makes my card
work again.
Broadcom folks, that is the correct test? This needs to be fixed
urgently.
next prev parent reply other threads:[~2009-09-11 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 22:15 5717 support commit is buggy David Miller
2009-09-11 22:41 ` David Miller [this message]
2009-09-11 23:11 ` Matt Carlson
2009-09-11 23:33 ` Matt Carlson
2009-09-11 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911.154125.182458823.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benli@broadcom.com \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).