From: "Matt Carlson" <mcarlson@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"Benjamin Li" <benli@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: 5717 support commit is buggy
Date: Fri, 11 Sep 2009 16:33:52 -0700 [thread overview]
Message-ID: <20090911233352.GA12633@xw6200.broadcom.net> (raw)
In-Reply-To: <20090911.151554.181296228.davem@davemloft.net>
On Fri, Sep 11, 2009 at 03:15:54PM -0700, David Miller wrote:
> Also:
>
> @@ -13486,7 +13556,8 @@ static void __devinit tg3_init_link_config(struct tg3 *tp)
>
> static void __devinit tg3_init_bufmgr_config(struct tg3 *tp)
> {
> - if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
> + if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS &&
> + GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717) {
> tp->bufmgr_config.mbuf_read_dma_low_water =
> DEFAULT_MB_RDMA_LOW_WATER_5705;
> tp->bufmgr_config.mbuf_mac_rx_low_water =
>
> I wonder what that does with C precedence rules. Probably need
> parenhesis around "tp->tg3_flags2 & TG3_FLG2_5705_PLUS" for
> safety.
Harbison & Steele says '&' takes precedence over '&&'. That said, I'm
not shy about adding parens to remove any doubt.
I'm brewing another patchset that contains a patch to address things
like this. I'll add this to that patch.
next prev parent reply other threads:[~2009-09-11 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 22:15 5717 support commit is buggy David Miller
2009-09-11 22:41 ` David Miller
2009-09-11 23:11 ` Matt Carlson
2009-09-11 23:33 ` Matt Carlson [this message]
2009-09-11 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911233352.GA12633@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=benli@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).