From: David Miller <davem@davemloft.net>
To: jaswinder@kernel.org
Cc: gabriele.paoloni@intel.com, paulus@samba.org,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ppp: ppp_generic.c initialize flen before it get used
Date: Sat, 12 Sep 2009 23:17:26 -0700 (PDT) [thread overview]
Message-ID: <20090912.231726.165876349.davem@davemloft.net> (raw)
In-Reply-To: <1252773691.3687.5.camel@ht.satnam>
Already dealt with in net-next-2.6, please act against the
active networking development trees when fixing warnings and
doing cleanups.
Thank you.
commit 886f9fe68310168358f55028a03553ae154dfeb6
Author: David S. Miller <davem@davemloft.net>
Date: Wed Aug 19 13:55:55 2009 -0700
ppp_generic: Help GCC see that 'flen' is always initialized.
It's too stupid to see that we always set flen to something
before we use it in ppp_mp_explode():
drivers/net/ppp_generic.c: In function 'ppp_push':
drivers/net/ppp_generic.c:1314: warning: 'flen' may be used uninitialized in this function
drivers/net/ppp_generic.c:1314: note: 'flen' was declared here
This started warning after commit a53a8b56827cc429c6d9f861ad558beeb5f6103f
("ppp: fix lost fragments in ppp_mp_explode() (resubmit)")
So just put an explicit unconditional initialization there to
hush it up.
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2009-09-13 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 16:41 [PATCH] ppp: ppp_generic.c initialize flen before it get used Jaswinder Singh Rajput
2009-09-13 6:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912.231726.165876349.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gabriele.paoloni@intel.com \
--cc=jaswinder@kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).