From: Robert Varga <nite@hq.alert.sk>
To: netdev@vger.kernel.org
Subject: tcp_put_md5sig_pool() from tcp_twsk_destructor()?
Date: Sat, 12 Sep 2009 03:04:01 +0200 [thread overview]
Message-ID: <20090912010401.GA28539@hq.alert.sk> (raw)
Hi,
I have recently came across a preemption imbalance detected by:
<4>huh, entered ffffffff80644630 with preempt_count 00000102, exited with 00000101?
<0>------------[ cut here ]------------
<2>kernel BUG at /usr/src/linux/kernel/timer.c:664!
<0>invalid opcode: 0000 [1] PREEMPT SMP
with ffffffff80644630 being inet_twdr_hangman().
This appeared after I enabled CONFIG_TCP_MD5SIG and played with it a
bit, so I looked at what might have caused it.
One thing that struck me as strange is tcp_twsk_destructor(), as that
calls tcp_put_md5sig_pool() -- which entails a put_cpu(), which does not
make sense to me -- and would explain the imbalance.
Shouldn't tcp_twsk_destructor() be calling tcp_free_md5sig_pool()
instead?
Please CC: me, as I am not subscribed to the list.
--
Bye,
Robert Varga
Reality continues to ruin my life. -- Calvin
reply other threads:[~2009-09-12 1:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912010401.GA28539@hq.alert.sk \
--to=nite@hq.alert.sk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).