* tcp_put_md5sig_pool() from tcp_twsk_destructor()?
@ 2009-09-12 1:04 Robert Varga
0 siblings, 0 replies; only message in thread
From: Robert Varga @ 2009-09-12 1:04 UTC (permalink / raw)
To: netdev
Hi,
I have recently came across a preemption imbalance detected by:
<4>huh, entered ffffffff80644630 with preempt_count 00000102, exited with 00000101?
<0>------------[ cut here ]------------
<2>kernel BUG at /usr/src/linux/kernel/timer.c:664!
<0>invalid opcode: 0000 [1] PREEMPT SMP
with ffffffff80644630 being inet_twdr_hangman().
This appeared after I enabled CONFIG_TCP_MD5SIG and played with it a
bit, so I looked at what might have caused it.
One thing that struck me as strange is tcp_twsk_destructor(), as that
calls tcp_put_md5sig_pool() -- which entails a put_cpu(), which does not
make sense to me -- and would explain the imbalance.
Shouldn't tcp_twsk_destructor() be calling tcp_free_md5sig_pool()
instead?
Please CC: me, as I am not subscribed to the list.
--
Bye,
Robert Varga
Reality continues to ruin my life. -- Calvin
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-12 1:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-12 1:04 tcp_put_md5sig_pool() from tcp_twsk_destructor()? Robert Varga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).