* [PATCH] Phonet: Netlink event for autoconfigured addresses
@ 2009-09-14 13:10 Rémi Denis-Courmont
2009-09-14 13:10 ` [PATCH] cdc-phonet: remove noisy debug statement Rémi Denis-Courmont
2009-09-15 0:08 ` [PATCH] Phonet: Netlink event for autoconfigured addresses David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Rémi Denis-Courmont @ 2009-09-14 13:10 UTC (permalink / raw)
To: netdev; +Cc: Rémi Denis-Courmont
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
net/phonet/pn_dev.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index 2f65dca..5f42f30 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -209,7 +209,14 @@ static int phonet_device_autoconf(struct net_device *dev)
SIOCPNGAUTOCONF);
if (ret < 0)
return ret;
- return phonet_address_add(dev, req.ifr_phonet_autoconf.device);
+
+ ASSERT_RTNL();
+ ret = phonet_address_add(dev, req.ifr_phonet_autoconf.device);
+ if (ret)
+ return ret;
+ phonet_address_notify(RTM_NEWADDR, dev,
+ req.ifr_phonet_autoconf.device);
+ return 0;
}
/* notify Phonet of device events */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cdc-phonet: remove noisy debug statement
2009-09-14 13:10 [PATCH] Phonet: Netlink event for autoconfigured addresses Rémi Denis-Courmont
@ 2009-09-14 13:10 ` Rémi Denis-Courmont
2009-09-15 0:08 ` David Miller
2009-09-15 0:08 ` [PATCH] Phonet: Netlink event for autoconfigured addresses David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Rémi Denis-Courmont @ 2009-09-14 13:10 UTC (permalink / raw)
To: netdev; +Cc: Rémi Denis-Courmont
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
drivers/net/usb/cdc-phonet.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c
index 97e54d9..33d5c57 100644
--- a/drivers/net/usb/cdc-phonet.c
+++ b/drivers/net/usb/cdc-phonet.c
@@ -264,7 +264,6 @@ static int usbpn_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
switch (cmd) {
case SIOCPNGAUTOCONF:
req->ifr_phonet_autoconf.device = PN_DEV_PC;
- printk(KERN_CRIT"device is PN_DEV_PC\n");
return 0;
}
return -ENOIOCTLCMD;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Phonet: Netlink event for autoconfigured addresses
2009-09-14 13:10 [PATCH] Phonet: Netlink event for autoconfigured addresses Rémi Denis-Courmont
2009-09-14 13:10 ` [PATCH] cdc-phonet: remove noisy debug statement Rémi Denis-Courmont
@ 2009-09-15 0:08 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-09-15 0:08 UTC (permalink / raw)
To: remi; +Cc: netdev, remi.denis-courmont
From: Rémi Denis-Courmont <remi@remlab.net>
Date: Mon, 14 Sep 2009 16:10:27 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdc-phonet: remove noisy debug statement
2009-09-14 13:10 ` [PATCH] cdc-phonet: remove noisy debug statement Rémi Denis-Courmont
@ 2009-09-15 0:08 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-09-15 0:08 UTC (permalink / raw)
To: remi; +Cc: netdev, remi.denis-courmont
From: Rémi Denis-Courmont <remi@remlab.net>
Date: Mon, 14 Sep 2009 16:10:28 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-15 0:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-14 13:10 [PATCH] Phonet: Netlink event for autoconfigured addresses Rémi Denis-Courmont
2009-09-14 13:10 ` [PATCH] cdc-phonet: remove noisy debug statement Rémi Denis-Courmont
2009-09-15 0:08 ` David Miller
2009-09-15 0:08 ` [PATCH] Phonet: Netlink event for autoconfigured addresses David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).