From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
peter.p.waskiewicz.jr@intel.com, donald.c.skidmore@intel.com
Subject: Re: [net-next PATCH 1/3] ixgbe: Properly disable packet split per-ring when globally disabled
Date: Mon, 14 Sep 2009 17:08:30 -0700 (PDT) [thread overview]
Message-ID: <20090914.170830.108659301.davem@davemloft.net> (raw)
In-Reply-To: <20090914174659.4560.28814.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 14 Sep 2009 10:47:27 -0700
> From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
>
> The packet split feature was recently moved out of the adapter-wide flags
> feature field and into a per-Rx ring feature field. In the process, packet
> split isn't properly disabled in the Rx ring if the adapter has it globally
> disabled, followed by a device reset.
>
> This won't impact the driver today, since it's always in packet split mode.
> However, this will prevent any pitfalls if someone disables packet split on
> the adapter in the future and doesn't disable it in each ring.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Applied.
prev parent reply other threads:[~2009-09-15 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 17:47 [net-next PATCH 1/3] ixgbe: Properly disable packet split per-ring when globally disabled Jeff Kirsher
2009-09-14 17:47 ` [net-next PATCH 2/3] ixgbe: Add support for 82599-based CX4 adapters Jeff Kirsher
2009-09-15 0:08 ` David Miller
2009-09-14 17:48 ` [net-next PATCH 3/3] ixgbe: Create separate media type for " Jeff Kirsher
2009-09-15 0:08 ` David Miller
2009-09-15 0:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914.170830.108659301.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).