From: David Miller <davem@davemloft.net>
To: oliver@hartkopp.net
Cc: stable@kernel.org, netdev@vger.kernel.org, urs@isnogud.escape.de,
mb@bu3sch.de
Subject: Re: [PATCH] can: fix NOHZ local_softirq_pending 08 warning
Date: Tue, 15 Sep 2009 01:31:40 -0700 (PDT) [thread overview]
Message-ID: <20090915.013140.97444184.davem@davemloft.net> (raw)
In-Reply-To: <4AAF3AF2.60309@hartkopp.net>
From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Tue, 15 Sep 2009 08:57:54 +0200
> When using nanosleep() in an userspace application we get a ratelimit warning
>
> NOHZ: local_softirq_pending 08
>
> for 10 times.
>
> The echo of CAN frames is done from process context and softirq context only.
> Therefore the usage of netif_rx() was wrong (for years).
>
> This patch replaces netif_rx() with netif_rx_ni() which has to be used from
> process/softirq context. It also adds a missing comment that can_send() must
> no be used from hardirq context.
>
> Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
> Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Applied, thanks.
prev parent reply other threads:[~2009-09-15 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 6:57 [PATCH] can: fix NOHZ local_softirq_pending 08 warning Oliver Hartkopp
2009-09-15 8:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915.013140.97444184.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
--cc=stable@kernel.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).