From: David Miller <davem@davemloft.net>
To: yi.zhu@intel.com
Cc: mel@csn.ul.ie, reinette.chatre@intel.com, elendil@planet.nl,
Larry.Finger@lwfinger.net, linville@tuxdriver.com,
penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, akpm@linux-foundation.org,
cl@linux-foundation.org, assaf.krauss@intel.com,
johannes@sipsolutions.net, mohamed.abbas@intel.com,
netdev@vger.kernel.org
Subject: Re: alloc skb based on a given data buffer
Date: Tue, 15 Sep 2009 02:09:03 -0700 (PDT) [thread overview]
Message-ID: <20090915.020903.93643290.davem@davemloft.net> (raw)
In-Reply-To: <1253005050.7549.58.camel@debian>
From: Zhu Yi <yi.zhu@intel.com>
Date: Tue, 15 Sep 2009 16:57:29 +0800
> Thanks. So we can put the 8K buffer into 2 skb_shinfo()->frags[] slots
> and set nr_frags to 2, right? Is this supported allover the network code
> already? At a first glance, I didn't find any frags handling in mac80211
> stack.
You have to pre-pull the link level protocol headers into the
linear area, but that's it.
Again, see niu.c for details, it does:
static void niu_rx_skb_append(struct sk_buff *skb, struct page *page,
u32 offset, u32 size)
{
int i = skb_shinfo(skb)->nr_frags;
skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
frag->page = page;
frag->page_offset = offset;
frag->size = size;
skb->len += size;
skb->data_len += size;
skb->truesize += size;
skb_shinfo(skb)->nr_frags = i + 1;
}
to add pages to SKBs and then at the end it goes:
skb_reserve(skb, NET_IP_ALIGN);
__pskb_pull_tail(skb, min(len, NIU_RXPULL_MAX));
Right before giving the SKB to the networking stack. NIU_RXPULL_MAX
should be a value that will be large enough to cover the largest
possible link level header.
next prev parent reply other threads:[~2009-09-15 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909060941.01810.elendil@planet.nl>
[not found] ` <4AA67139.80301@lwfinger.net>
[not found] ` <20090909150418.GI24614@csn.ul.ie>
[not found] ` <200909091759.33655.elendil@planet.nl>
[not found] ` <20090909165545.GK24614@csn.ul.ie>
[not found] ` <1252526738.30150.91.camel@rc-desk>
[not found] ` <20090910090206.GA22276@csn.ul.ie>
[not found] ` <1252617290.30150.321.camel@rc-desk>
[not found] ` <20090911084717.GB32497@csn.ul.ie>
[not found] ` <1252897270.5650.169.camel@debian>
[not found] ` <20090914130612.GA11778@csn.ul.ie>
2009-09-15 8:30 ` alloc skb based on a given data buffer Zhu Yi
2009-09-15 8:33 ` David Miller
2009-09-15 8:57 ` Zhu Yi
2009-09-15 9:09 ` David Miller [this message]
2009-09-15 9:15 ` Zhu Yi
2009-09-15 15:30 ` Johannes Berg
[not found] ` <1253028631.23427.55.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-09-15 21:16 ` David Miller
2009-09-19 5:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915.020903.93643290.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=assaf.krauss@intel.com \
--cc=cl@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mel@csn.ul.ie \
--cc=mohamed.abbas@intel.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).