From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] RxRPC: Declare the security index constants symbolically
Date: Tue, 15 Sep 2009 02:46:11 -0700 (PDT) [thread overview]
Message-ID: <20090915.024611.108935670.davem@davemloft.net> (raw)
All 4 patches applied, but...
The rxrpc code seems to use a hodge-podge of uint32_t, uint16_t et
al. and the Linux kernel preferred "u8".
Please consolidate it all to use u32, u16, etc.
This looks especially weird since you use the endianness aware
fixed sized Linux types (be32, be16) as well.
next reply other threads:[~2009-09-15 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 9:46 David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-14 11:17 [PATCH 1/4] RxRPC: Declare the security index constants symbolically David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915.024611.108935670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).