From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] pkt_sched: Fix tx queue selection in tc_modify_qdisc
Date: Tue, 15 Sep 2009 02:53:21 -0700 (PDT) [thread overview]
Message-ID: <20090915.025321.178672469.davem@davemloft.net> (raw)
In-Reply-To: <20090914225022.GA13363@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Tue, 15 Sep 2009 00:50:22 +0200
> -----------------------> (take 2)
> pkt_sched: Fix tx queue selection in tc_modify_qdisc
>
> After the recent mq change there is the new select_queue qdisc class
> method used in tc_modify_qdisc, but it works OK only for direct child
> qdiscs of mq qdisc. Grandchildren always get the first tx queue, which
> would give wrong qdisc_root etc. results (e.g. for sch_htb as child of
> sch_prio). This patch fixes it by using parent's dev_queue for such
> grandchildren qdiscs. The select_queue method's return type is changed
> BTW.
>
> With feedback from: Patrick McHardy <kaber@trash.net>
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks Jarek.
prev parent reply other threads:[~2009-09-15 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 12:22 [PATCH] pkt_sched: Fix tx queue selection in tc_modify_qdisc Jarek Poplawski
2009-09-14 18:05 ` Patrick McHardy
2009-09-14 19:03 ` Jarek Poplawski
2009-09-14 22:50 ` [PATCH v2] " Jarek Poplawski
2009-09-15 9:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915.025321.178672469.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).