From: David Miller <davem@davemloft.net>
To: jens@mcbone.net
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [RFC] net/core: Delay neighbor only if it has been used after confirmed
Date: Tue, 15 Sep 2009 03:13:50 -0700 (PDT) [thread overview]
Message-ID: <20090915.031350.61645231.davem@davemloft.net> (raw)
In-Reply-To: <1253009246.8352.10.camel@fnki-nb00130>
From: Jens Rosenboom <jens@mcbone.net>
Date: Tue, 15 Sep 2009 12:07:26 +0200
> On Thu, 2009-09-10 at 18:21 +0200, Jens Rosenboom wrote:
>> On Wed, 2009-09-02 at 21:22 +0900, YOSHIFUJI Hideaki wrote:
>> [...]
>> > And, this "if" for REACHABLE->DELAY may be completely needless.
>> > Timer in REACHABLE is only for state transition for toward REACHABLE
>> > or STALE.
>>
>> I did some testing with the following patch, which works fine for me, so
>> I propose this one now instead of my previous one. I still have no real
>> idea about the non-IPv6 implications of this, though.
>>
>> ---
>>
>> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
>> index e587e68..f61926f 100644
>> --- a/net/core/neighbour.c
>> +++ b/net/core/neighbour.c
>> @@ -819,13 +819,6 @@ static void neigh_timer_handler(unsigned long arg)
>> neigh->confirmed + neigh->parms->reachable_time)) {
>> NEIGH_PRINTK2("neigh %p is still alive.\n", neigh);
>> next = neigh->confirmed + neigh->parms->reachable_time;
>> - } else if (time_before_eq(now,
>> - neigh->used + neigh->parms->delay_probe_time)) {
>> - NEIGH_PRINTK2("neigh %p is delayed.\n", neigh);
>> - neigh->nud_state = NUD_DELAY;
>> - neigh->updated = jiffies;
>> - neigh_suspect(neigh);
>> - next = now + neigh->parms->delay_probe_time;
>> } else {
>> NEIGH_PRINTK2("neigh %p is suspected.\n", neigh);
>> neigh->nud_state = NUD_STALE;
>>
>
> Hi David, what are your thoughts on this one? There is IMHO a real bug
> to fix, namely sending tons of repeated neighbor solicitations when
> there is no actual traffic to be sent, so this should qualify to go into
> 2.6.32. Do you want to wait for further comments or should I submit this
> for net-2.6 so it can get some testing?
I'm waiting for Yoshifuji's feedback to your latest patch.
prev parent reply other threads:[~2009-09-15 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 9:17 [RFC] net/core: Delay neighbor only if it has been used after confirmed Jens Rosenboom
2009-09-02 12:22 ` YOSHIFUJI Hideaki
2009-09-02 13:03 ` Jens Rosenboom
2009-09-10 16:21 ` Jens Rosenboom
2009-09-15 10:07 ` Jens Rosenboom
2009-09-15 10:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915.031350.61645231.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jens@mcbone.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).