From: David Miller <davem@davemloft.net>
To: dwalker@fifo99.com
Cc: jie.yang@atheros.com, miles.lane@gmail.com,
chris.snook@gmail.com, jcliburn@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0: DMA-API: device driver frees DMA
Date: Wed, 16 Sep 2009 02:47:59 -0700 (PDT) [thread overview]
Message-ID: <20090916.024759.51103835.davem@davemloft.net> (raw)
In-Reply-To: <1253092251.11643.569.camel@desktop>
From: Daniel Walker <dwalker@fifo99.com>
Date: Wed, 16 Sep 2009 02:10:51 -0700
> On Wed, 2009-09-16 at 14:21 +0800, jie.yang@atheros.com wrote:
>> - pci_unmap_page(pdev, tx_buffer->dma,
>> + if (tx_buffer->flags & ATL1E_TX_PCIMAP_SINGLE)
>> + pci_unmap_single(pdev, tx_buffer->dma,
>> + tx_buffer->length, PCI_DMA_TODEVICE);
>> + else if (tx_buffer->flags & ATL1E_TX_PCIMAP_PAGE)
>> + pci_unmap_page(pdev, tx_buffer->dma,
>
> Could you run this through checkpatch, and fix any errors if find? It
> looks like you uses spaces for tabs in the code above, maybe in the
> other block too..
>
It's because of his email client, it corrupted the whole patch
like that.
next prev parent reply other threads:[~2009-09-16 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 6:21 [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0: DMA-API: device driver frees DMA jie.yang
2009-09-16 6:57 ` David Miller
2009-09-16 9:10 ` Daniel Walker
2009-09-16 9:31 ` Jie Yang
2009-09-16 9:47 ` David Miller [this message]
2009-09-16 9:51 ` Cyrill Gorcunov
2009-09-16 9:54 ` Jie Yang
-- strict thread matches above, loose matches on Subject: below --
2009-09-16 7:23 jie.yang
2009-09-16 7:44 ` David Miller
2009-09-16 9:28 jie.yang
2009-09-17 17:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916.024759.51103835.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.snook@gmail.com \
--cc=dwalker@fifo99.com \
--cc=jcliburn@gmail.com \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).