From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: jpirko@redhat.com, netdev@vger.kernel.org,
bonding-devel@lists.sourceforge.net, nicolas.2p.debian@free.fr
Subject: Re: [PATCH net-next-2.6] bonding: make ab_arp select active slaves as other modes
Date: Wed, 16 Sep 2009 17:05:20 -0700 (PDT) [thread overview]
Message-ID: <20090916.170520.233815224.davem@davemloft.net> (raw)
In-Reply-To: <30814.1253145765@death.nxdomain.ibm.com>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Wed, 16 Sep 2009 17:02:45 -0700
> Jiri Pirko <jpirko@redhat.com> wrote:
>
>>When I was implementing primary_passive option (formely named primary_lazy) I've
>>run into troubles with ab_arp. This is the only mode which is not using
>>bond_select_active_slave() function to select active slave and instead it
>>selects it itself. This seems to be not the right behaviour and it would be
>>better to do it in bond_select_active_slave() for all cases. This patch makes
>>this happen. Please review.
>>
>>Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
> I tried to break this, and couldn't. Tested with regular
> ethernet interfaces, as well as VLANs, and it does the right thing.
>
> -J
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks everyone.
prev parent reply other threads:[~2009-09-17 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 21:09 [PATCH net-next-2.6] bonding: make ab_arp select active slaves as other modes Jiri Pirko
2009-09-11 0:32 ` Jay Vosburgh
2009-09-15 15:08 ` Jiri Pirko
2009-09-15 16:20 ` Jay Vosburgh
2009-09-15 18:55 ` Jiri Pirko
2009-09-17 0:02 ` Jay Vosburgh
2009-09-17 0:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916.170520.233815224.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).