From: David Miller <davem@davemloft.net>
To: greg@kroah.com
Cc: netdev@vger.kernel.org, Charles.Li@Micrel.Com, Choi@kroah.com,
David.Choi@Micrel.Com, jgarzik@redhat.com, shemminger@vyatta.com
Subject: Re: [PATCH] ks8851_ml ethernet network driver
Date: Wed, 16 Sep 2009 20:48:01 -0700 (PDT) [thread overview]
Message-ID: <20090916.204801.190052862.davem@davemloft.net> (raw)
In-Reply-To: <20090917023836.GA15260@kroah.com>
From: Greg KH <greg@kroah.com>
Date: Wed, 16 Sep 2009 19:38:36 -0700
> From: Choi, David <David.Choi@Micrel.Com>
>
> This is a network driver for the ks8851 16bit MLL ethernet device.
>
> Signed-off-by: David J. Choi <david.choi@micrel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This doesn't even build cleanly:
drivers/net/ks8851_mll.c: In function ‘ks_inblk’:
drivers/net/ks8851_mll.c:555: warning: cast from pointer to integer of different size
drivers/net/ks8851_mll.c:558: warning: passing argument 1 of ‘_readw’ makes pointer from integer without a cast
drivers/net/ks8851_mll.c: In function ‘ks_outblk’:
drivers/net/ks8851_mll.c:571: warning: cast from pointer to integer of different size
drivers/net/ks8851_mll.c:574: warning: passing argument 2 of ‘_writew’ makes pointer from integer without a cast
It also has a big "#define DEBUG" at the beginning of the driver.
And it also has stuff like:
+#define MALLOC(x) kmalloc(x, GFP_KERNEL)
which actually decreases the readability of this driver.
Please fix this up.
next prev parent reply other threads:[~2009-09-17 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 2:38 [PATCH] ks8851_ml ethernet network driver Greg KH
2009-09-17 3:48 ` David Miller [this message]
2009-09-17 13:03 ` Greg KH
2009-09-17 19:06 ` Choi, David
2009-09-17 19:30 ` Choi, David
2009-09-17 23:49 ` David Miller
2009-09-18 5:27 ` Greg KH
2009-09-24 23:02 ` [PATCH] ks8851_ml ethernet network driver - FIXED LINE-WRAPPING ISSUE Choi, David
2009-09-24 23:39 ` David Miller
2009-09-25 17:58 ` [PATCH] drivers/net: ks8851 ethernet network driver - RESUBMIT Choi, David
2009-09-25 19:09 ` David Miller
2009-09-26 0:42 ` [PATCH 2.6.31-rc9] drivers/net: ks8851_mll ethernet network driver Choi, David
2009-10-01 3:05 ` David Miller
2009-10-01 14:51 ` Choi, David
2009-09-17 4:03 ` [PATCH] ks8851_ml " Stephen Hemminger
2009-09-17 19:11 ` Choi, David
2009-09-17 4:07 ` Stephen Hemminger
2009-09-17 19:20 ` Choi, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916.204801.190052862.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Charles.Li@Micrel.Com \
--cc=Choi@kroah.com \
--cc=David.Choi@Micrel.Com \
--cc=greg@kroah.com \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).