* [PATCH] ipv6: Log the affected address when DAD failure occurs
@ 2009-09-16 11:44 Jens Rosenboom
2009-09-17 17:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jens Rosenboom @ 2009-09-16 11:44 UTC (permalink / raw)
To: Linux Network Developers
From: Jens Rosenboom <me@jayr.de>
If an interface has multiple addresses, the current message for DAD
failure isn't really helpful, so this patch adds the address itself to
the printk.
Signed-off-by: Jens Rosenboom <me@jayr.de>
---
This is a resubmit of http://patchwork.ozlabs.org/patch/31196/ which
erroneously was marked as superseded, but using the new compact output format.
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index c9b3690..907a6f7 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1405,8 +1405,8 @@ void addrconf_dad_failure(struct inet6_ifaddr *ifp)
struct inet6_dev *idev = ifp->idev;
if (net_ratelimit())
- printk(KERN_INFO "%s: IPv6 duplicate address detected!\n",
- ifp->idev->dev->name);
+ printk(KERN_INFO "%s: IPv6 duplicate address %pI6c detected!\n",
+ ifp->idev->dev->name, &ifp->addr);
if (idev->cnf.accept_dad > 1 && !idev->cnf.disable_ipv6) {
struct in6_addr addr;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: Log the affected address when DAD failure occurs
2009-09-16 11:44 [PATCH] ipv6: Log the affected address when DAD failure occurs Jens Rosenboom
@ 2009-09-17 17:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-09-17 17:24 UTC (permalink / raw)
To: me; +Cc: netdev
From: Jens Rosenboom <me@jayr.de>
Date: Wed, 16 Sep 2009 13:44:37 +0200
> From: Jens Rosenboom <me@jayr.de>
>
> If an interface has multiple addresses, the current message for DAD
> failure isn't really helpful, so this patch adds the address itself to
> the printk.
>
> Signed-off-by: Jens Rosenboom <me@jayr.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-17 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16 11:44 [PATCH] ipv6: Log the affected address when DAD failure occurs Jens Rosenboom
2009-09-17 17:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).