From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Danny Feng <dfeng@redhat.com>
Cc: Shan Wei <shanwei@cn.fujitsu.com>,
davem@davemloft.net, kaber@trash.net, yoshfuji@linux-ipv6.org,
jmorris@namei.org, pekkas@netcore.fi, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Marc Milgram <mmilgram@redhat.com>
Subject: Re: [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct
Date: Thu, 17 Sep 2009 13:36:22 +0400 [thread overview]
Message-ID: <20090917093622.GA19142@ms2.inr.ac.ru> (raw)
In-Reply-To: <4AB1FF14.6000801@redhat.com>
Hello!
On Thu, Sep 17, 2009 at 05:19:16PM +0800, Danny Feng wrote:
> In fact, current implemetation supports:
>
> struct ip_mreqn mreqn;
> setsockopt(socket, IPPROTO_IP, IP_MULTICAST_IF, &mreqn, sizeof(mreqn));
>
> Then why not support mreq?
Because support of ip_mreqn makes sense (it user interface index)
and support of ip_mreq, which does not contain interface index,
does not. "Polymorphic" IP_MULTICAST_IF was a stupid mistake (mine),
which should not grow like a tumor.
Ack to patch #1, nack to #2.
Alexey
prev parent reply other threads:[~2009-09-17 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 5:20 [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct Xiaotian Feng
2009-09-17 9:16 ` Shan Wei
2009-09-17 9:19 ` Danny Feng
2009-09-17 9:36 ` Alexey Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090917093622.GA19142@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mmilgram@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shanwei@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).