From: David Miller <davem@davemloft.net>
To: jaswinder@kernel.org
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-pcmcia@lists.infradead.org, linux@dominikbrodowski.net
Subject: Re: [RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition
Date: Tue, 22 Sep 2009 14:17:16 -0700 (PDT) [thread overview]
Message-ID: <20090922.141716.236597540.davem@davemloft.net> (raw)
In-Reply-To: <1252782529.3687.26.camel@ht.satnam>
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
Date: Sun, 13 Sep 2009 00:38:49 +0530
> [This is untested]
>
> 'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
> So removing useless 'if (i < NR_INFO)'
>
> This also fixed following compilation warning :
>
> CC [M] drivers/net/pcmcia/pcnet_cs.o
> drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
> drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Looks good to me, applied.
prev parent reply other threads:[~2009-09-22 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 19:08 [RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition Jaswinder Singh Rajput
2009-09-22 21:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922.141716.236597540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jaswinder@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).