From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org, ian.saturley@smsc.com, vlad.lyalikov@smsc.com
Subject: Re: [PATCH] smsc95xx: fix transmission where ZLP is expected
Date: Tue, 22 Sep 2009 14:19:45 -0700 (PDT) [thread overview]
Message-ID: <20090922.141945.211402736.davem@davemloft.net> (raw)
In-Reply-To: <1253628027-2704-1-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 22 Sep 2009 15:00:27 +0100
> Usbnet framework assumes USB hardware doesn't handle zero length
> packets, but SMSC LAN95xx requires these to be sent for correct
> operation.
>
> This patch fixes an easily reproducible tx lockup when sending a frame
> that results in exactly 512 bytes in a USB transmission (e.g. a UDP
> frame with 458 data bytes, due to IP headers and our USB headers). It
> adds an extra flag to usbnet for the hardware driver to indicate that
> it can handle and requires the zero length packets.
>
> This patch should not affect other usbnet users, please also consider
> for -stable.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Applied, thanks.
prev parent reply other threads:[~2009-09-22 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 14:00 [PATCH] smsc95xx: fix transmission where ZLP is expected Steve Glendinning
2009-09-22 21:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922.141945.211402736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
--cc=vlad.lyalikov@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).